Thanks to visit codestin.com
Credit goes to github.com

Skip to content

fix: respect custom TalkerLogger output in TalkerFlutter.init #367

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 19, 2025
Merged

fix: respect custom TalkerLogger output in TalkerFlutter.init #367

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
27 changes: 16 additions & 11 deletions packages/talker_flutter/lib/src/extensions/talker_flutter.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
import 'dart:developer';
import 'dart:developer' show log;

import 'package:flutter/foundation.dart';
import 'package:talker_flutter/talker_flutter.dart';
Expand All @@ -11,25 +11,30 @@ extension TalkerFlutter on Talker {
TalkerFilter? filter,
}) =>
Talker(
logger: (logger ?? TalkerLogger()).copyWith(
output: _defaultFlutterOutput,
),
settings: settings,
logger: logger ?? TalkerLogger(output: _defaultFlutterOutput),
observer: observer,
settings: settings,
filter: filter,
);

static dynamic _defaultFlutterOutput(String message) {
/// Default output function for Flutter:
/// - On web, prints to console.
/// - On iOS/macOS, uses `dart:developer.log`.
/// - On other platforms, uses `debugPrint`.
static void _defaultFlutterOutput(String message) {
if (kIsWeb) {
// ignore: avoid_print
print(message);
return;
}
if ([TargetPlatform.iOS, TargetPlatform.macOS]
.contains(defaultTargetPlatform)) {
log(message, name: 'Talker');
return;

switch (defaultTargetPlatform) {
case TargetPlatform.iOS:
case TargetPlatform.macOS:
log(message, name: 'Talker');
break;
default:
debugPrint(message);
}
debugPrint(message);
}
}
5 changes: 4 additions & 1 deletion packages/talker_flutter/pubspec_overrides.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,7 @@
dependency_overrides:
talker:
path:
../talker
../talker
talker_logger:
path:
../talker_logger