Thanks to visit codestin.com
Credit goes to github.com

Skip to content

chore: update share_plus to v11.0.0 #369

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jun 18, 2025
Merged

chore: update share_plus to v11.0.0 #369

merged 2 commits into from
Jun 18, 2025

Conversation

@jeroenbell
Copy link
Contributor

@jeroenbell jeroenbell commented May 12, 2025 •
edited by sourcery-ai bot
Loading

The latest version of share_plus deprecated some methods in favor of a new recommended one. This PR updates the dependency and replaces the deprecated method with the recommended one.

This is to avoid version conflicts for projects that depend on both share_plus and talker_flutter.

Summary by Sourcery

Update the share_plus dependency to v11.0.0 and replace the deprecated shareXFiles call with the new SharePlus.instance.share API.

Enhancements:

  • Replace deprecated Share.shareXFiles with SharePlus.instance.share using ShareParams

Build:

  • Bump share_plus dependency to version 11.0.0

@sourcery-ai
Copy link
Contributor

sourcery-ai bot commented May 12, 2025 •
edited
Loading

Reviewer's Guide

Upgrades share_plus to v11.0.0 and migrates deprecated Share.shareXFiles usage to the new SharePlus.instance.share API to maintain compatibility and avoid version conflicts.

File-Level Changes

Change Details Files
Bump share_plus dependency version
  • Updated share_plus version constraint from ^10.0.1 to ^11.0.0 in pubspec.yaml
 packages/talker_flutter/pubspec.yaml
Migrate from Share.shareXFiles to SharePlus.instance.share
  • Removed the call to Share.shareXFiles
  • Introduced SharePlus.instance.share with ShareParams
  • Wrapped file path in XFile and passed it via ShareParams
 packages/talker_flutter/lib/src/utils/download_logs/download_logs_native.dart

Possibly linked issues

  • #0: PR updates share_plus dependency and code to resolve compatibility issue reported in the issue.
Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

sourcery-ai[bot]
sourcery-ai bot reviewed May 12, 2025
View reviewed changes
Copy link
Contributor

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @jeroenbell - I've reviewed your changes and they look great!

Here's what I looked at during the review
  • 🟢 General issues: all looks good
  • 🟢 Security: all looks good
  • 🟢 Testing: all looks good
  • 🟢 Complexity: all looks good
  • 🟢 Documentation: all looks good
Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

@Frezyx Frezyx added the v5 Related to new package big release 5.0.0 label May 19, 2025
@Frezyx Frezyx added the talker_flutter Related to talker_flutter package label May 21, 2025
@Frezyx Frezyx linked an issue May 28, 2025 that may be closed by this pull request
Provide compatibility to share_plus 11.0.0 #373
Closed
@Frezyx Frezyx merged commit d973002 into Frezyx:master Jun 18, 2025
1 check passed
@Frezyx Frezyx removed the v5 Related to new package big release 5.0.0 label Jun 18, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@sourcery-ai sourcery-ai[bot] sourcery-ai[bot] left review comments

@Frezyx Frezyx Frezyx approved these changes

Assignees

No one assigned

Labels

talker_flutter Related to talker_flutter package

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Provide compatibility to share_plus 11.0.0

2 participants

@jeroenbell @Frezyx