-
-
Couldn't load subscription status.
- Fork 101
Feature: Add Custom Log Documentation #378
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature: Add Custom Log Documentation #378
Conversation
Reviewer's GuideEnhances the README customβlog documentation by refactoring the example class to use static getters with instance overrides, and by expanding both CLI (TalkerSettings colors and titles) and Flutter (TalkerScreen theme) examples to clearly illustrate default and custom log configuration patterns and ANSI color limitations in widgets. Sequence Diagram: Configuring Talker using YourCustomLog Static PropertiessequenceDiagram
actor Developer
participant YCL as YourCustomLog
participant TS as TalkerSettings
participant T as Talker
Developer->>YCL: Access static YourCustomLog.getKey()
activate YCL
YCL-->>Developer: logKey
deactivate YCL
Developer->>YCL: Access static YourCustomLog.getPen()
activate YCL
YCL-->>Developer: logPen
deactivate YCL
Developer->>YCL: Access static YourCustomLog.getTitle()
activate YCL
YCL-->>Developer: logTitle
deactivate YCL
Developer->>TS: new TalkerSettings(titles: {logKey: logTitle}, colors: {logKey: logPen})
activate TS
TS-->>Developer: configuredSettings
deactivate TS
Developer->>T: new Talker(settings: configuredSettings)
activate T
T-->>Developer: talkerInstance
deactivate T
File-Level Changes
Possibly linked issues
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @MeyerOppelt - I've reviewed your changes - here's some feedback:
- The Dart sample code contains syntax errors (e.g.,
String super.messageforwarding constructor and missing parentheses onAnsiPeninvocations) β please ensure the examples compile. - Static getters for
getTitle,getKey, andgetPencould be replaced withstatic constfields or more straightforward overrides to simplify the API. - The sample configuration maps contain duplicate entries for
YourCustomLog.getKey; consider removing repetitions to keep examples concise.
Here's what I looked at during the review
- π‘ General issues: 3 issues found
- π’ Security: all looks good
- π’ Testing: all looks good
- π’ Complexity: all looks good
- π’ Documentation: all looks good
Help me be more useful! Please click π or π on each comment and I'll use the feedback to improve your reviews.
|
Fixed issues pointed out by Sourcery. Except for the Also did not fix repetition as it is explaining valid ways to use custom log colors. |
|
@sourcery-ai review |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @MeyerOppelt - I've reviewed your changes - here's some feedback:
- Using static getters named getTitle/getKey/getPen adds unnecessary verbosity; consider using static const properties or simpler static getters named title/key/pen instead.
- Several examples define the same map key twice (e.g., YourCustomLog.getKey) which can be misleading; consolidate each key into a single example entry for clarity.
Here's what I looked at during the review
- π‘ General issues: 1 issue found
- π’ Security: all looks good
- π’ Testing: all looks good
- π’ Complexity: all looks good
- π’ Documentation: all looks good
Help me be more useful! Please click π or π on each comment and I'll use the feedback to improve your reviews.
|
Hello @MeyerOppelt ! |
Thanks a lot for contributing!
#354
Added custom log documentation to make it more similar to the example app, and less confusing for first-time users
Summary by Sourcery
Revise and expand the custom log documentation in the README to demonstrate a new pattern using static getters for title, key, and pen, and to provide comprehensive examples for customizing log titles and colors in both Dart console and Flutter contexts.
Documentation: