Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Conversation

@j-signorelli
Copy link
Contributor

Closes #347

@najlkin najlkin self-requested a review December 5, 2025 20:11
@najlkin najlkin self-assigned this Dec 5, 2025
@najlkin
Copy link
Contributor

najlkin commented Dec 5, 2025

Yay, we are running into problems with ambiguity of byte, which is defined in C++17, but apparently it collides with some declaration in Visual Studio headers 😬 . Maybe we can fix it by just moving using namespace std in vsdata.cpp🤔 .

@najlkin
Copy link
Contributor

najlkin commented Dec 6, 2025

Nope, it comes from somewhere else due to the namespace pollution 🫤 . I have cleaned that up in #336 , so I transplanted that here. Let us see if it works...

@j-signorelli
Copy link
Contributor Author

Thanks so much @najlkin for looking into this

@najlkin najlkin changed the title Update std to C++17 Update CMake standard to C++17 Dec 6, 2025
@najlkin
Copy link
Contributor

najlkin commented Dec 6, 2025

It works! 🎉

@najlkin najlkin changed the title Update CMake standard to C++17 Update C++ standard to 17 Dec 6, 2025
@najlkin
Copy link
Contributor

najlkin commented Dec 15, 2025

@tzanio , we need to merge this asap as GLVis cannot be compiled with MFEM 4.9/master with CMake without it and all CMake CI jobs are failing due to that 😱 (like here).

@tzanio tzanio requested a review from helloworld922 December 16, 2025 20:51
Copy link
Member

@tzanio tzanio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @najlkin !

Comment on lines +16 to 18
set(CMAKE_CXX_STANDARD 17)
set(CMAKE_CXX_STANDARD_REQUIRED ON)
set(CMAKE_CXX_EXTENSIONS OFF)

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

With mfem/mfem#5163 these three lines can be removed and glvis can just track mfem's C++ version. Should be fine to leave these for now so users can build with the 4.9 release.

@najlkin najlkin merged commit ad19b98 into GLVis:master Dec 18, 2025
19 of 20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

CMake compile fails without C++17 Standard

4 participants