-
Notifications
You must be signed in to change notification settings - Fork 56
Update C++ standard to 17 #348
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Yay, we are running into problems with ambiguity of |
|
Nope, it comes from somewhere else due to the namespace pollution 🫤 . I have cleaned that up in #336 , so I transplanted that here. Let us see if it works... |
|
Thanks so much @najlkin for looking into this |
|
It works! 🎉 |
tzanio
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @najlkin !
| set(CMAKE_CXX_STANDARD 17) | ||
| set(CMAKE_CXX_STANDARD_REQUIRED ON) | ||
| set(CMAKE_CXX_EXTENSIONS OFF) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
With mfem/mfem#5163 these three lines can be removed and glvis can just track mfem's C++ version. Should be fine to leave these for now so users can build with the 4.9 release.
Closes #347