Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Conversation

@yousseb
Copy link
Contributor

@yousseb yousseb commented Feb 25, 2016

OSX / patch-set number 3

@yousseb
Copy link
Contributor Author

yousseb commented Feb 25, 2016

This one is a bit tricky...

  1. The is_darwin() will resolve to true on the native build. It will also resolve to true on MacPorts. However, there is not 3.x build for MacPorts (I'm not sure about Brew)
  2. What I intend to do is to further improve the is_darwin method so that it checks if it's running on Quartz instead of checking just the OS. This is why I created it as a separate method in conf and didn't check for the OS within the meldwindow.py
  3. Merging the patch will allow others to help me out on this.

@yousseb yousseb mentioned this pull request Feb 25, 2016
@gnomesysadmins
Copy link

Thank you for contributing to meld!

meld uses Bugzilla for code review.

If you have never contributed to GNOME before make sure you have read the
getting started documentation:
http://www.gnome.org/get-involved

Otherwise please visit
https://wiki.gnome.org/Newcomers/CodeContributionWorkflow
and follow the instructions there to upload your change to Bugzilla.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants