Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Conversation

@cdmatters
Copy link
Contributor

No description provided.

st-- and others added 12 commits April 20, 2020 08:43
Ensure that the `leading_transpose` function can be used with the @tf.function decorator (workaround for bug in tensorflow<=2.2.0rc3)
Previously, GPflow's NaturalGradient optimizer would call the loss_function once for each (q_mu, q_sqrt) set in the var_list. This is a light refactor that separates out applying the natural gradient step from computing the gradients (`_natgrad_apply_gradients`), and changes `_natgrad_steps` to only evaluate the loss function once, computing the gradients for all (q_mu, q_sqrt) tuples passed in the var_list.

Other changes:
- The no-longer-used `_natgrad_step` method got removed.
- NaturalGradient now takes a `xi_transform` argument that is used for all parameter sets without explicitly specified xi transform (i.e. tuples rather than triplets).
- XiTransform has been changed to have staticmethods.

None of this should affect any downstream code; this PR is backwards-compatible.
…1453)

* includes the repr() string in IPython/Jupyter notebook representation as well (i.e. fully-qualified class name and object hash (memory address), which helps distinguish objects from each other)
* only displays the parameter table when it is not empty
* makes use of default_summary_fmt() for IPython shell
@codecov
Copy link

codecov bot commented May 7, 2020

Codecov Report

Merging #1459 into master will decrease coverage by 0.07%.
The diff coverage is 90.74%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1459      +/-   ##
==========================================
- Coverage   95.39%   95.31%   -0.08%     
==========================================
  Files          82       82              
  Lines        3732     3759      +27     
==========================================
+ Hits         3560     3583      +23     
- Misses        172      176       +4     
Impacted Files Coverage Δ
gpflow/covariances/kufs.py 100.00% <ø> (ø)
gpflow/base.py 92.08% <50.00%> (-3.34%) ⬇️
gpflow/optimizers/natgrad.py 84.55% <86.84%> (+1.66%) ⬆️
...ow/conditionals/multioutput/sample_conditionals.py 100.00% <100.00%> (ø)
gpflow/conditionals/sample_conditionals.py 94.11% <100.00%> (-0.33%) ⬇️
gpflow/conditionals/util.py 76.14% <100.00%> (+0.12%) ⬆️
gpflow/kernels/changepoints.py 100.00% <100.00%> (ø)
gpflow/models/gplvm.py 99.21% <100.00%> (ø)
gpflow/models/gpmc.py 94.87% <100.00%> (+0.13%) ⬆️
gpflow/models/gpr.py 100.00% <100.00%> (ø)
... and 8 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3fc050d...6ce4203. Read the comment docs.

@cdmatters cdmatters merged commit 5e599fb into master May 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants