Thanks to visit codestin.com
Credit goes to github.com

Skip to content

fix bug of issue #2091 by type checking A #2096

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
uri-granta merged 2 commits into from
Dec 19, 2023
Merged

fix bug of issue #2091 by type checking A #2096

uri-granta merged 2 commits into from
Dec 19, 2023

Conversation

@JSchmiegel
Copy link
Contributor

@JSchmiegel JSchmiegel commented Dec 8, 2023

PR type: bugfix

Related issue(s)/PRs: resolves #2091

Summary

Proposed changes

  • type check A
  • throws error if the Parameter does not have the correct shape

What alternatives have you considered?

Minimal working example

Release notes

Fully backwards compatible: yes

PR checklist

  • The bug case / new feature is covered by unit tests
  • Code has type annotations
  • Build checks
    • I ran the black+isort formatter (make format)
    • I locally tested that the tests pass (make check-all)
  • Release management
    • RELEASE.md updated with entry for this change
    • New contributors: I've added myself to CONTRIBUTORS.md

@JSchmiegel
Copy link
Contributor Author

JSchmiegel commented Dec 13, 2023

Sorry, but I am unsure, if I understand correctly, this merge is blocked because format checker tests fail. However, if I actually apply the make format-check command to the project, then I would change 67 files (that I have not changed in my original pull request). That seems a bit much to me. Is that correct? Should I commit it like this?

@uri-granta uri-granta self-requested a review December 14, 2023 15:46
uri-granta
uri-granta reviewed Dec 14, 2023
View reviewed changes
Copy link
Member

@uri-granta uri-granta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you very much for writing this (and sorry for taking so long to get to look at it). I've added a few comments and suggestions. Feel free to ask if anything is unclear!

@codecov
Copy link

codecov bot commented Dec 15, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (5d4c222) 98.19% compared to head (d389eaa) 98.19%.

Additional details and impacted files 
@@           Coverage Diff            @@
##           develop    #2096   +/-   ##
========================================
  Coverage    98.19%   98.19%           
========================================
  Files           97       97           
  Lines         5486     5490    +4     
========================================
+ Hits          5387     5391    +4     
  Misses          99       99

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

uri-granta
uri-granta approved these changes Dec 18, 2023
View reviewed changes
Copy link
Member

@uri-granta uri-granta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks!

@uri-granta uri-granta merged commit dca094b into GPflow:develop Dec 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@uri-granta uri-granta uri-granta approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Set a prior over a linear mean function

2 participants

@JSchmiegel @uri-granta