[LG-14462] Add footer links #506
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I recall some discussion around the width of the footer. We have some different styles in dev docs that made the wider footer make sense… |
ajfarkas
requested changes
Oct 31, 2024
aduth
reviewed
Oct 31, 2024
|
Screenshots after latest updates Mobile breakpointMiddle breakpointAbove 1024px |
nprimak
approved these changes
Nov 4, 2024
nprimak
reviewed
Nov 4, 2024
Gemfile.lock
Outdated
|
|
||
| RUBY VERSION | ||
| ruby 3.2.5p208 | ||
| ruby 3.2.6p234 |
There was a problem hiding this comment.
Did you update this because of the CircleCI Ruby version error? I merged in a PR on Friday that fixes that so you might not need this anymore.
There was a problem hiding this comment.
Yes. Though since this works, I don't see a compelling reason to roll back. Happy to revert if you think I should
There was a problem hiding this comment.
Rebased just to make sure nothing breaks and I do have to roll this back after your Friday changes
There was a problem hiding this comment.
Thanks! Sorry for the extra trouble.
ajfarkas
approved these changes
Nov 4, 2024
aduth
reviewed
Nov 4, 2024
e286eac to
0b725f3
Compare
Co-authored-by: Andrew Duthie <[email protected]>
Co-authored-by: Andrew Duthie <[email protected]>
0b725f3 to
2fa2b9c
Compare
nprimak
approved these changes
Nov 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Added footer links to match what exists on the main site. I tried to copy and paste as much as applicable from https://github.com/GSA-TTS/identity-site and then reconcile any apparent CSS duplication. I did not try to include the translation-based options from identity-site as that seemed like scope creep for this ticket.
I added the font anti-aliasing setting that's on the main page with the intention of keeping the sites looking consistent.
Screenshots
The previous dev docs footer
The new dev docs footer
The current Login.gov footer
You may notice that the left and right margins / padding on the main site footer are different than those on the dev docs. This was true before this PR. Fixing them in this PR seemed to me like it would likely be more complicated than the rest of the effort on this PR so far a relatively small benefit, so I felt stopping here was good enough for now.
Before font anti-aliasing
After font anti-aliasing
Especially in screenshots, I find the font anti-aliasing more noticeable in the body paragraph text than in the footer itself, so here's a comparison. The anti-aliased version is definitely closer visually to what's on the main site.