Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Comments

Electronic documents, chapter shortname, pa11y-ci update#283

Merged
dmundra merged 4 commits intomainfrom
electronic-documents-chapter-shortname
Jan 21, 2022
Merged

Electronic documents, chapter shortname, pa11y-ci update#283
dmundra merged 4 commits intomainfrom
electronic-documents-chapter-shortname

Conversation

@dmundra
Copy link
Collaborator

@dmundra dmundra commented Jan 20, 2022

A lot of changes, here is a summary:

  1. Renaming 'Electronic Docs' to 'Electronic Documents' for Change "Electronic Docs" to "Electronic Documents" #280
  2. Added short_label to the chapter object for the catalog schema so we don't have to have a separate file in the editor for those values.
  3. Updated pa11y-ci to latest version so it running more up to date axe-core checks. Did have to ignore contract checks because it cannot calculate the contrast of the table header.
  4. With the package changes I updated the license file. See https://github.com/GSA/openacr/tree/main/license for details.

QA

  1. Review the HTML and Markdown files to confirm the rename of 'Electronic Docs' to 'Electronic Documents'. You can download generated HTML from the GitHub action: https://github.com/GSA/openacr/actions/runs/1725653905
  2. Short label will be tested in the editor.
  3. Confirm the a11y-tests run without errors.

@dmundra dmundra requested review from mgifford and qjac January 20, 2022 21:22
@dmundra dmundra self-assigned this Jan 20, 2022
@dmundra dmundra enabled auto-merge (squash) January 20, 2022 21:48
@dmundra
Copy link
Collaborator Author

dmundra commented Jan 20, 2022

@qjac I tagged @mgifford as a reviewer as well just so he is aware of changes but I want you to be the primary so you can review the code and ask questions. Thank you!

@qjac
Copy link
Collaborator

qjac commented Jan 20, 2022

"Short label will be tested in the editor." @dmundra

Is there a url to test or do I pull it down locally to QA?

@dmundra
Copy link
Collaborator Author

dmundra commented Jan 20, 2022

"Short label will be tested in the editor." @dmundra

Is there a url to test or do I pull it down locally to QA?

Ah, the plan to add it here and then after this merges pull down the updated version in the editor and then use the new key there. So nothing to test here.

Copy link
Collaborator

@qjac qjac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good 👍

@dmundra dmundra merged commit 642f833 into main Jan 21, 2022
@dmundra dmundra deleted the electronic-documents-chapter-shortname branch January 21, 2022 00:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants