Flash Attention support #78
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Starting from pytorch dev image instead of lightning. This is important since flash-attn requires cudatoolkit-dev which needs conda. Instead, easier to start with a dev docker container. Added install for flash-attn.
Current install should work fine for those who don't need flash-attn as flash-attn relevant imports are in the FlashAttention function itself.
avantikalal
requested changes
Oct 25, 2024
…ransformerBlock as optional and reordered them
for more information, see https://pre-commit.ci
avantikalal
approved these changes
Oct 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
flash_attnflag inBorzoiModelthat switches to flash attention.flash-attn. Dockerfile includesflash-attn.pip install gReLUstill works ifflash-attnis not required as it is only imported when called.Solves #64