[PATCH] fix base64/fingerprint certFile confusion #91
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
looks good to me, looks like this functionality was broken in PR #84 |
servusdei2018
suggested changes
Aug 7, 2021
Co-authored-by: Nate <[email protected]>
HarmJ0y
approved these changes
Aug 12, 2021
|
Sorry it took so long, my test lab died a tragic death. I got it back up enough to test and no longer observe the crash with asktgt. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
asktgtcan be given a fingerprint to use ascertFile, but it doesn't work as it is interpreted as base64 encoded first. This patch fixes this bug.