Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Comments

Fix diag switch#4762

Merged
arturcic merged 2 commits intoGitTools:mainfrom
davidjenni:fix-diag-switch
Nov 26, 2025
Merged

Fix diag switch#4762
arturcic merged 2 commits intoGitTools:mainfrom
davidjenni:fix-diag-switch

Conversation

@davidjenni
Copy link
Contributor

@davidjenni davidjenni commented Nov 25, 2025 •
edited
Loading

Description

Fix to accept /diag switch in any argument position on cmd line, not just the last argument position.

Related Issues

Resolves #4763

It also addresses the root cause of #4395 but also improves mitigation for #4539

Motivation and Context

Discovered when debugging issue #4539 (diag flag not working). While this is not the root cause for 4539, without the fix in this PR, possible workarounds for 4539 are more brittle.

How Has This Been Tested?

added unit tests to arg parser suite.

Screenshots (if appropriate):

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@davidjenni
fix: /diag behaves like a proper boolean switch
178b1d3 
before fix, order of arguments mattered:
- unless /diag is last argument, it is ignored; and the following
  argument is swalloed silently

/diag /l gv.log  -> diagnostic switch is ignored, no log file is created
/l console /diag -> diagnostic output is emitted to console
/l gv.log /diag  -> diagnostic output is emitted to log file
@davidjenni
test: -diag switch order in arg list doesn't matter
0b54846
@sonarqubecloud
Copy link

sonarqubecloud bot commented Nov 25, 2025

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@davidjenni davidjenni marked this pull request as ready for review November 25, 2025 23:45
@davidjenni davidjenni mentioned this pull request Nov 26, 2025
Closed
2 tasks
@arturcic arturcic self-requested a review November 26, 2025 05:32
@arturcic arturcic linked an issue Nov 26, 2025 that may be closed by this pull request
[ISSUE]: 6.3.0 diag flag not working #4539
Closed
2 tasks
@arturcic arturcic removed a link to an issue Nov 26, 2025
[ISSUE]: 6.3.0 diag flag not working #4539
Closed
2 tasks
arturcic
arturcic approved these changes Nov 26, 2025
View reviewed changes
Copy link
Member

@arturcic arturcic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

@arturcic arturcic merged commit 24cf318 into GitTools:main Nov 26, 2025
118 checks passed
@mergify
Copy link
Contributor

mergify bot commented Nov 26, 2025

Thank you @davidjenni for your contribution!

@arturcic
Copy link
Member

arturcic commented Nov 26, 2025

@davidjenni thanks for taking the time to debug this

@arturcic arturcic added this to the 6.x milestone Nov 26, 2025
@asbjornu
Copy link
Member

asbjornu commented Nov 26, 2025

Thank you so much for fixing this @davidjenni! Should we perhaps update the documentation for this as well?

@arturcic
Copy link
Member

arturcic commented Nov 26, 2025

Thank you so much for fixing this @davidjenni! Should we perhaps update the documentation for this as well?

I think he was suggesting that #4539 (comment)

@asbjornu
Copy link
Member

asbjornu commented Nov 26, 2025

Thank you so much for fixing this @davidjenni! Should we perhaps update the documentation for this as well?

I think he was suggesting that #4539 (comment)

Indeed!

cmd line help and documentation should be updated

Yes, please! 😊 🙏🏼

@davidjenni davidjenni mentioned this pull request Nov 26, 2025
Merged
@arturcic arturcic added the bug label Nov 27, 2025
@gittools-bot
Copy link
Contributor

gittools-bot commented Nov 27, 2025

🎉 This issue has been resolved in version 6.5.1 🎉
The release is available on:

Your GitReleaseManager bot 📦🚀

This was referenced Nov 27, 2025
Merged
Closed
Merged
Merged
Open
Closed
Merged
Open
Merged
Merged
Merged
This was referenced Dec 15, 2025
Merged
Merged
Closed
Merged
Open
This was referenced Jan 1, 2026
Closed
Open
Merged
Merged
Merged
Closed
This was referenced Feb 1, 2026
Open
Closed
Closed
Closed
This was referenced Feb 9, 2026
Closed
Closed
Open
Open
This was referenced Feb 16, 2026
Closed
Open
Open
Open
Open
Open
Open
Open
Open
Open
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@arturcic arturcic arturcic approved these changes

Assignees

No one assigned

Labels

bug

Projects

None yet

Milestone

6.5.1

Development

Successfully merging this pull request may close these issues.

[ISSUE]: /diag is ignored if not last argument

4 participants

@davidjenni @arturcic @asbjornu @gittools-bot