report: remove eslint --fix step in report generation#13864
Merged
brendankenny merged 2 commits intomasterfrom Apr 16, 2022
Merged
report: remove eslint --fix step in report generation#13864brendankenny merged 2 commits intomasterfrom
brendankenny merged 2 commits intomasterfrom
Conversation
| @@ -4,27 +4,27 @@ | |||
|
|
|||
| /** @typedef {import('./dom.js').DOM} DOM */ | |||
|
|
|||
| /* eslint-disable max-len */ | |||
| /* eslint-disable max-len, quotes, comma-spacing */ | |||
Collaborator
There was a problem hiding this comment.
LGTM
but maybe we should just disable eslint entirely?
Contributor
Author
There was a problem hiding this comment.
I was originally going to do that but then I saw how few rules were needed. It's nice to have it close to our lint style since it's little effort to get it there. If it ever really needs to diverge it's no big deal to disable, of course.
connorjclark
approved these changes
Apr 16, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The time needed for
yarn build-reportwas really a drag today :)With a few tweaks and eslint-ignoring spacing after commas and double quotes,
report/renderer/components.jscan still otherwise pass our eslint rules without a call toeslint --fix.On my machine this drops
yarn build-report --standalonedown about 45%, to ~2.25s.