Thanks to visit codestin.com
Credit goes to github.com

Skip to content

tests: call toString for errors from bundled worker #15245

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
connorjclark merged 1 commit into from
Jul 11, 2023
Merged

tests: call toString for errors from bundled worker #15245

connorjclark merged 1 commit into from
Jul 11, 2023

Conversation

@connorjclark
Copy link
Collaborator

@connorjclark connorjclark commented Jul 11, 2023

Error objects can't be sent from a worker, so all we get is {} printed on errors.

@connorjclark connorjclark requested a review from a team as a code owner July 11, 2023 00:58
@connorjclark connorjclark requested review from adamraine and removed request for a team July 11, 2023 00:58
@connorjclark connorjclark merged commit 24a6214 into main Jul 11, 2023
@connorjclark connorjclark deleted the tostring-smoke branch July 11, 2023 17:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@adamraine adamraine adamraine approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@adamraine adamraine

Labels

waiting4reviewer

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@connorjclark @adamraine @devtools-bot