core(seo): improve validation for invalid canonical URLs #16765
+60
−26
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #12008
Summary
This PR fixes a bug in the canonical audit where some syntactically invalid URLs (e.g., those with a space in the host like
https:// example.com) were incorrectly being classified as relative URLs.The previous validation logic was insufficient because it didn't correctly handle cases where the browser's link parser would return a non-null, but still malformed,
hrefstring.This change replaces the old logic with a more robust, two-step validation process inside a nested
try...catchblock.hrefRawis syntactically valid at all by attempting to construct a URL with a base. If this fails, the URL is correctly marked as invalid.To support this fix, the existing unit tests have been improved:
href: nullscenario, improving the overall robustness of the test suite.All related unit tests now pass with these changes.