Thanks to visit codestin.com
Credit goes to github.com

Skip to content

report: fix focus in devtools, and in 3-dot menu #16802

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
connorjclark merged 4 commits into from
Jan 12, 2026
+6 −3
Merged

report: fix focus in devtools, and in 3-dot menu #16802

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
f1c6ef9
report: fix focus in devtools, and in 3-dot menu
connorjclark Dec 15, 2025
225b1c3
fix e2e cdt
connorjclark Dec 15, 2025
42190c0
Merge branch 'main' into fix-focus-2025
connorjclark Dec 15, 2025
20d63b1
Merge branch 'main' into fix-focus-2025
connorjclark Jan 12, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions report/assets/styles.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -285,6 +285,10 @@
--section-padding-vertical: 8px;
}

.lh-devtools :focus-visible {
outline: -webkit-focus-ring-color auto 1px;
Copy link
Member

@paulirish paulirish Jan 12, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure this actually has an effect.

We have https://source.chromium.org/chromium/chromium/src/+/main:third_party/devtools-frontend/src/front_end/panels/lighthouse/lighthousePanel.css;l=67-79;drc=50b0c0e46c8405292b411920fafd672a1c73cb51 over in the DT side which appears to override both this and the inherit below.

oooooooooooh lol dsv@ did that at the same time as you were writing this PR.

🤣

Copy link
Member

@paulirish paulirish Jan 12, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

so...

question is if you want to remove that outline:inherit globally. if you dont care then seems like we can close this PR.?

Copy link
Collaborator Author

@connorjclark connorjclark Jan 12, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I prefer to define non-theming/size stuff (devtools style tokens) within our stylesheet here, so want to keep the focus outline rule.

and the inherit just causes problems so I want that gone too

}

.lh-container:has(.lh-sticky-header) {
--sticky-header-buffer: calc(var(--topbar-height) + var(--sticky-header-height));
}
Expand Down
1 change: 0 additions & 1 deletion report/assets/templates.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -224,7 +224,6 @@
border: none;
padding: 0;
font: inherit;
outline: inherit;
}
.lh-tools__button svg {
fill: var(--tools-icon-color);
Expand Down
4 changes: 2 additions & 2 deletions report/renderer/components.js
View file
Open in desktop

Large diffs are not rendered by default.

Loading