Thanks to visit codestin.com
Credit goes to github.com

Skip to content

feat(bufferedread): Handle -1 for read.global-max-blocks as infinite #3855

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
vipnydav merged 1 commit into from
Sep 30, 2025
Merged

feat(bufferedread): Handle -1 for read.global-max-blocks as infinite #3855

vipnydav merged 1 commit into from
Sep 30, 2025

Conversation

@vipnydav
Copy link
Member

@vipnydav vipnydav commented Sep 30, 2025

Description

This PR handles the -1 value for read.global-max-blocks. When this parameter is set to -1, it will be interpreted as an infinite value and set to math.MaxInt32.

Link to the issue in case of a bug fix.

https://b.corp.google.com/issues/448271034

Testing details

  1. Manual - Done
  2. Unit tests - Added
  3. Integration tests - NA

Any backward incompatible change? If so, please explain.

@vipnydav vipnydav requested a review from a team as a code owner September 30, 2025 08:37
@vipnydav vipnydav requested a review from raj-prince September 30, 2025 08:37
@github-actions github-actions bot added the remind-reviewers Auto remind reviewers in attention set for review post 24hrs of inactivity on PR. label Sep 30, 2025
raj-prince
raj-prince reviewed Sep 30, 2025
View reviewed changes
@vipnydav vipnydav enabled auto-merge (squash) September 30, 2025 09:13
@vipnydav vipnydav merged commit a90c9b9 into master Sep 30, 2025
17 of 18 checks passed
@codecov
Copy link

codecov bot commented Sep 30, 2025 •
edited
Loading

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 82.62%. Comparing base (596541d) to head (fa48d32).
⚠️ Report is 3 commits behind head on master.

Additional details and impacted files 
@@           Coverage Diff           @@
##           master    #3855   +/-   ##
=======================================
  Coverage   82.62%   82.62%           
=======================================
  Files         145      145           
  Lines       23257    23262    +5     
=======================================
+ Hits        19215    19220    +5     
  Misses       3499     3499           
  Partials      543      543
Flag Coverage Δ
unittests 82.62% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@vipnydav vipnydav deleted the read-global-max-blocks-handling branch September 30, 2025 09:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@raj-prince raj-prince raj-prince approved these changes

Assignees

No one assigned

Labels

remind-reviewers Auto remind reviewers in attention set for review post 24hrs of inactivity on PR.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@vipnydav @raj-prince