feat(bufferedread): Limit channel size in buffered reader by number of workers. #3857
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
raj-prince
approved these changes
Oct 1, 2025
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #3857 +/- ##
===========================================
+ Coverage 0 82.63% +82.63%
===========================================
Files 0 145 +145
Lines 0 23266 +23266
===========================================
+ Hits 0 19227 +19227
- Misses 0 3497 +3497
- Partials 0 542 +542
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR limits the channel size in static worker pool by the number of workers available as at a time the max tasks that be executed equals the number of workers and also when
--read-global-max-blocksis set to-1it tries to create a very large channel which takes upto52sduring mount and is not needed.Link to the issue in case of a bug fix.
b/448570386
Testing details
Any backward incompatible change? If so, please explain.