fix: fixing anonymous access flag while creating client #4093
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #4093 +/- ##
==========================================
+ Coverage 83.27% 83.35% +0.07%
==========================================
Files 153 153
Lines 18600 18602 +2
==========================================
+ Hits 15490 15505 +15
+ Misses 2539 2531 -8
+ Partials 571 566 -5
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
/gemini summary |
|
/gemini review |
|
Hi @vadlakondaswetha, @raj-prince, your feedback is needed to move this pull request forward. This automated reminder was triggered because there has been no activity for over 24 hours. Please provide your input when you have a moment. Thank you! |
raj-prince
approved these changes
Dec 3, 2025
ashmeenkaur
pushed a commit
that referenced
this pull request
Dec 12, 2025
* fixing anonmous flag fix * adding unit test
ashmeenkaur
pushed a commit
that referenced
this pull request
Dec 12, 2025
* fixing anonmous flag fix * adding unit test
ashmeenkaur
pushed a commit
that referenced
this pull request
Dec 12, 2025
* fixing anonmous flag fix * adding unit test
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Since 3.5.1,
enable-google-lib-authis set to true, which causes a cred.UniverseDomain query even for existing clients that set anonymous-access to disable authentication.Link to the issue in case of a bug fix.
b/465254339
Testing details
Any backward incompatible change? If so, please explain.