Add modifier functionality, tests, commands, and documentation #132
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Once again, sorry for how big this PR is... it's hard to split this functionality up into smaller PRs, since it touches a lot of the code. It should be noted that this PR will conflict with #131 |
fce2033 to
00d7bb1
Compare
00d7bb1 to
3023eed
Compare
|
OK, Merge conflicts should have been dealt with, and this PR is now ready to review / merge. |
rfbgo
reviewed
Jun 2, 2023
rfbgo
approved these changes
Jun 8, 2023
rfbgo
previously approved these changes
Jun 8, 2023
21eef66 to
f6b41a8
Compare
This commit updates the repository methods to include a modifier type in addition to the default object and application types. Additionally, it generalizes some of the type specific methods, updates references, adds a schema for a modifier_repos file, and updates tests to have modifier and application specific mock functionality.
This commit adds the schema definition for how modifiers are defined, and adds the plumbing to propagate modifiers from their configs (in workspace config or the config section) into the application instance. Nothing happens with modifiers yet, aside from their definitions being set correctly.
This commit adds the ability for modifiers to modify applications
This commit implements the modifier functionality. Now modifiers are applied to application instances, and correctly modify the various aspects of the instance. Workspace concretization is updated to allow modifiers to be concretized while experiments are concretized.
This commit adds a `ramble mods` command for interacting with modifiers. Additionally, this unifies some of the shared backends for info and list commands for applications and modifiers.
This commit adds tests for modifier functionality, the mods command, and adds tags and descriptions to existing modifiers.
f6b41a8 to
0f75f5b
Compare
rfbgo
approved these changes
Jun 9, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This merge represents major new functionality. This adds support for modifiers to Ramble.
Modifiers are classes that are allowed to modify various aspects of ramble experiments. These can inject commands, change variable definitions, add figures of merit, and many other things.
Modifiers are implemented similar to application definitions. This merge adds support for modifier repositories, which can live next to application repositories, or in independent locations.
Modifier application is controlled through the ramble.yaml configuration file, and documentation describing this is added.