Remove support for deprecated env-vars #151
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
Author
|
This PR is blocked by #144 |
4acb414 to
2720173
Compare
This commit removes v1 spack support, and several v1 helper methods.
This commit removes support for env-vars, and transitions to env_vars instead.
2720173 to
e87f20f
Compare
rfbgo
previously approved these changes
Jun 8, 2023
Collaborator
rfbgo
left a comment
There was a problem hiding this comment.
LGTM. I'm going to let you chose the right time to merge this @douglasjacobsen since it might break existing users workflows
The merge-base changed after approval.
rfbgo
previously approved these changes
Jun 9, 2023
The merge-base changed after approval.
rfbgo
previously approved these changes
Jun 9, 2023
The merge-base changed after approval.
rfbgo
previously approved these changes
Jun 9, 2023
The merge-base changed after approval.
rfbgo
previously approved these changes
Jun 9, 2023
Collaborator
rfbgo
left a comment
There was a problem hiding this comment.
Last attempt to un-confuse GH before I force the merge
The merge-base changed after approval.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This merge removes support for the deprecated env-vars config sections.
Previously, environment variables were defined through the env-vars config section, but we transitioned to env_vars to allow the config section to be modifiable through
ramble configcommands. This merge completes this transition by removing support and warnings for the older format.