Re-order logger creation to avoid recusrive limit #261
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rfbgo
previously approved these changes
Sep 19, 2023
This commit removes the progress bar dependency, as it currently doesn't work with the way we use loggers. It also re-orders some of the logger creation logic to avoid a recusion limit depth error.
7a89ec2 to
e53aa55
Compare
rfbgo
approved these changes
Sep 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This merge removes the progress bar dependency, as it currently doesn't
work with the way we use loggers.
It also re-orders some of the logger creation logic to avoid a
recusion limit depth error.