Add a class to manage ramble reserved keywords #77
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rfbgo
requested changes
Mar 20, 2023
|
@douglasjacobsen can you fix up the conflict if you chose to implement some of my suggested changes too, please? |
4235d07 to
bcfd1a1
Compare
|
OK, Conflict is fixed now. |
This commit adds a new class (keywords) to house known ramble variable names. Logic is added using this to perform validation on different sets of variable definitions to ensure they are properly defined. Tests are also added to make sure the proper error messages are passed when varible names are incorrectly used.
This commit changes previously defined *_key references within other classes (expander and experiment_set) to use a unified keywords class to get the string names instead.
bcfd1a1 to
45f4279
Compare
rfbgo
previously approved these changes
Mar 21, 2023
This commit updates the expansion_str usage in the experiment_set module to be consistent, to address reviewer comments.
faea260 to
771b44c
Compare
rfbgo
approved these changes
Mar 21, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This merge introduces a new class to encapsulate all of the ramble known keywords, and their types.
Tests are added to make sure incorrectly defined keywords throw reasonable errors.
Additionally, past references to the
*_keytype keyword definitions are updated to use this class now.