Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Conversation

@douglasjacobsen
Copy link
Collaborator

This merge adds the ability to define custom executables in the YAML workspace configuration file.

Additionally, this adds the ability to control the executables used for creating the '{command}' variable within experiments.

@douglasjacobsen douglasjacobsen added the enhancement New feature or request label Mar 21, 2023
@douglasjacobsen douglasjacobsen requested a review from rfbgo March 22, 2023 19:44
@douglasjacobsen douglasjacobsen marked this pull request as ready for review March 22, 2023 19:44
@douglasjacobsen douglasjacobsen changed the title WIP: Add yaml support for custom executables and executable order control Add yaml support for custom executables and executable order control Mar 22, 2023
This commit adds support for `internals` dictionaries.

These can be defined at any level `variables` can be defined at, and are
used to control internal aspects of the application classes.

Currently support functionality includes:
```
internals:
  custom_executables:
    exec_name:
      template:
      - cmd1
      - cmd2
      use_mpi: true
      redirect: '{log_file}'
  executables:
  - exec_name
  - builtin::env_vars
```

The custom_executables dict allows the YAML to define custom executables
to build experiments with, while the executables list provides a list of
executables that will populate the '{command}' variable.
rfbgo
rfbgo previously approved these changes Mar 23, 2023
Copy link
Collaborator

@rfbgo rfbgo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Great to see how this was actually simple at it's core (but required adding lots of small changes)

This commit performs the following tasks:
- applies some additional `*_` syntax for consistency
- abstracts the `get_workspace_*` methods
- hoists an import in the application.py module
Copy link
Collaborator

@rfbgo rfbgo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Thanks for the changes

@rfbgo rfbgo merged commit 652a165 into GoogleCloudPlatform:develop Mar 24, 2023
@douglasjacobsen douglasjacobsen deleted the yaml_executables branch May 9, 2023 20:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants