Changes to simplify final_suspend() semantics. #36
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For paper P1477R0.
|
Also need to update [await.expr] to strip out mention of final_suspend |
GorNishanov
reviewed
Feb 7, 2019
lewissbaker
commented
Feb 7, 2019
added 3 commits
February 7, 2019 13:51
The final-suspend point is no longer defined in terms of co_await so this exclusion is not required.
…point. This is already covered by normative text in description of `coroutine_handle::resume()`.
lewissbaker
commented
Feb 8, 2019
| try { @\textit{F}@ } catch(...) { @\textit{p}@.unhandled_exception(); } | ||
| @\textit{final_suspend}@: | ||
| co_await @$p$@.final_suspend(); // final suspend point | ||
| // final suspend point |
There was a problem hiding this comment.
Does this still imply that the promise object and frame would be destructed if an exception was thrown from call to final_suspend()? Do we need to add some more wording to clarify that this is not the case?
There was a problem hiding this comment.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For paper P1477R0.