feat: Add VJP support for numpy.take function#744
Open
SIVALANAGASHANKARNIVAS wants to merge 2 commits intoHIPS:masterfrom
Open
feat: Add VJP support for numpy.take function#744SIVALANAGASHANKARNIVAS wants to merge 2 commits intoHIPS:masterfrom
SIVALANAGASHANKARNIVAS wants to merge 2 commits intoHIPS:masterfrom
Conversation
Implements gradient computation for numpy.take function. - Adds untake_along_axis primitive for scattering gradients back - Handles both axis=None (flattened) and specific axis cases - Uses numpy.add.at for proper gradient accumulation with repeated indices Fixes HIPS#743
Collaborator
|
Thanks @SIVALANAGASHANKARNIVAS – could you please add a few tests? 🙏🏻 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implements gradient computation for numpy.take function.
Fixes #743
Changes Made
This PR adds VJP (Vector-Jacobian Product) support for
numpy.take, enabling gradient computation through this function.Implementation Details
untake_along_axisprimitive that scatters gradients back to original array positionsaxis=None(flattened array) and specific axis casesnumpy.add.atfor proper gradient accumulation when indices are repeatedTesting
With this change, the following code now works: