Withdrawn changes from #2858 as they break ABI compat #2899
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ethouris
commented
Mar 5, 2024
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #2899 +/- ##
==========================================
+ Coverage 64.72% 65.01% +0.28%
==========================================
Files 101 101
Lines 17543 17525 -18
==========================================
+ Hits 11355 11394 +39
+ Misses 6188 6131 -57 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes in the logger.h file and changes following this one have been blocked.
These changes break ABI compatibility. Parts of the changes and dependent parties are in the header files in the form of inline functions, which are considered static part of the library and will get incompatible with the parallel changes in the shared library.
Other changes from #2858 remain, and some that interfere with the restored old version have been blocked.
All these changes will be restored in 1.6.0, for which it is allowed to break ABI compatibility.