Conversation
Adds the necessary configuration and the `npm run bench` script, as well as the first benchmark to verify everything is working. The first benchmark is permissionUtils. This is important to benchmark because permission strings are used often and there is some non-trivial logic such as escaping of full-colon characters. Other overheads like database access will be much more significant, but it may be useful to know how much more significant in quantifiable terms.
- Move CircularQueue class from AntiCSRFService to util directory - Add benchmark to ensure we don't slow it down
29e6781 to
16789b0
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.