Thanks to visit codestin.com
Credit goes to github.com

Skip to content

diagnostic: be clearer about what we support. #4450

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
MikeMcQuaid merged 1 commit into from
Jul 11, 2018
Merged

diagnostic: be clearer about what we support. #4450

MikeMcQuaid merged 1 commit into from
Jul 11, 2018

Conversation

@MikeMcQuaid
Copy link
Member

@MikeMcQuaid MikeMcQuaid commented Jul 10, 2018

And be even more explicit whose problem it is when things are broken.

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same change?
  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes? Here's an example.
  • Have you successfully run brew style with your changes locally?
  • Have you successfully run brew tests with your changes locally?

@ghost ghost assigned MikeMcQuaid Jul 10, 2018
@ghost ghost added the in progress Maintainers are working on this label Jul 10, 2018
claui
claui reviewed Jul 11, 2018
View reviewed changes
Library/Homebrew/extend/os/mac/diagnostic.rb Outdated
You will encounter build failures and other breakages.
Please create pull-requests instead of filing issues or asking the
Homebrew community for help. As you are running this #{what} you are
the person responsible for resolving your issues (not us).
Copy link
Contributor

@claui claui Jul 11, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

your issues → any issues to avoid discussions like “this is clearly $SOFTWARE’s fault so it’s actually not my issue”

@MikeMcQuaid
diagnostic: be clearer about what we support.
33dd2a7 
And be even more explicit whose problem it is when things are broken.
@MikeMcQuaid MikeMcQuaid merged commit 2e9d843 into Homebrew:master Jul 11, 2018
@ghost ghost removed the in progress Maintainers are working on this label Jul 11, 2018
@MikeMcQuaid MikeMcQuaid deleted the no-really-no-beta-support branch July 11, 2018 13:48
@lock lock bot added the outdated PR was locked due to age label Aug 10, 2018
@lock lock bot locked as resolved and limited conversation to collaborators Aug 10, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

1 more reviewer

@claui claui claui left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

@MikeMcQuaid MikeMcQuaid

Labels

outdated PR was locked due to age

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@MikeMcQuaid @claui