Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Conversation

@scpeters
Copy link
Contributor

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same change?
  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes? Here's an example.
  • Have you successfully run brew style with your changes locally?
  • Have you successfully run brew tests with your changes locally?

As discussed in Homebrew/homebrew-test-bot#172 (comment) and #4612, the local bottle filenames differ from the filename on bintray. So this adds the local filename as an extra field called local_filename to the json file generated by brew bottle --json.

Copy link
Member

@MikeMcQuaid MikeMcQuaid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me but I'd like @reitermarkus to give his thoughts too.

@MikeMcQuaid MikeMcQuaid merged commit 1c7c876 into Homebrew:master Aug 22, 2018
@MikeMcQuaid
Copy link
Member

Thanks @scpeters!

@scpeters scpeters deleted the bottle_json_local_filename branch August 22, 2018 15:54
@lock lock bot added the outdated PR was locked due to age label Sep 21, 2018
@lock lock bot locked as resolved and limited conversation to collaborators Sep 21, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

outdated PR was locked due to age

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants