Thanks to visit codestin.com
Credit goes to github.com

Skip to content

update-reset: fix Bash syntax. #5069

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
MikeMcQuaid merged 1 commit into from
Oct 8, 2018
Merged

update-reset: fix Bash syntax. #5069

MikeMcQuaid merged 1 commit into from
Oct 8, 2018

Conversation

@MikeMcQuaid
Copy link
Member

@MikeMcQuaid MikeMcQuaid commented Oct 8, 2018

This isn't valid syntax for a Bash array.

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same change?
  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes? Here's an example.
  • Have you successfully run brew style with your changes locally?
  • Have you successfully run brew tests with your changes locally?

@MikeMcQuaid
update-reset: fix Bash syntax.
06a66e2 
This isn't valid syntax for a Bash array.
colindean
colindean approved these changes Oct 8, 2018
View reviewed changes
Copy link
Contributor

@colindean colindean left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I always have a hard time remembering this because I don't use arrays in bash often enough, so I'm pasting it here for others to see, too:

Similar to mass-expanding positional parameters, this expands to all elements. If unquoted, both subscripts * and @ expand to the same result, if quoted, @ expands to all elements individually quoted, * expands to all elements quoted as a whole.

@MikeMcQuaid MikeMcQuaid merged commit c54a657 into Homebrew:master Oct 8, 2018
@MikeMcQuaid MikeMcQuaid deleted the update-reset-fix branch October 8, 2018 18:07
@MikeMcQuaid MikeMcQuaid mentioned this pull request Oct 8, 2018
Closed
4 tasks
@fxcoudert
Copy link
Member

fxcoudert commented Oct 9, 2018 •
edited
Loading

Even with this in all bottling fails on CI:

[Homebrew Bottles] $ /bin/sh -xe /tmp/jenkins3882460111858093096.sh
+ [ -d .git ]
+ rm -rf .git/refs/heads/*.lock Library/Taps/*/*/.git/refs/remotes/origin/*.lock
+ brew update-reset
/var/lib/jenkins/workspace/Homebrew Bottles/Library/Homebrew/cmd/update-reset.sh: line 29: ${REPOS[]}: bad substitution
Build step 'Execute shell' marked build as failure
[WS-CLEANUP] Deleting project workspace...[WS-CLEANUP] done
Finished: FAILURE

Example: https://jenkins.brew.sh/job/Homebrew%20Core%20Pull%20Requests/31558/downstreambuildview/
which was running well after this PR was merged.

@MikeMcQuaid
Copy link
Member Author

MikeMcQuaid commented Oct 9, 2018

@fxcoudert Fixed now, adding a manual git fetch && git reset to the bottle job.

@lock lock bot added the outdated PR was locked due to age label Nov 8, 2018
@lock lock bot locked as resolved and limited conversation to collaborators Nov 8, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

1 more reviewer

@colindean colindean colindean approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

outdated PR was locked due to age

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@MikeMcQuaid @fxcoudert @colindean