Thanks to visit codestin.com
Credit goes to github.com

Skip to content

download_strategy: move HOMEBREW_ARTIFACT_DOMAIN hack #15601

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 27, 2023
Merged

download_strategy: move HOMEBREW_ARTIFACT_DOMAIN hack #15601

merged 1 commit into from
Jun 27, 2023

Conversation

@Bo98
Copy link
Member

@Bo98 Bo98 commented Jun 27, 2023

Fixes #15600.

@Bo98 Bo98 mentioned this pull request Jun 27, 2023
Closed
3 tasks
jgarec
jgarec reviewed Jun 27, 2023
View reviewed changes
Copy link

@jgarec jgarec left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

works for me with this fix

@Bo98 Bo98 added the critical Critical change which should be shipped as soon as possible. label Jun 27, 2023
@Bo98 Bo98 merged commit eff45ef into Homebrew:master Jun 27, 2023
@Bo98 Bo98 deleted the artifact_domain-fix branch June 27, 2023 14:34
MikeMcQuaid
MikeMcQuaid reviewed Jun 27, 2023
View reviewed changes
Copy link
Member

@MikeMcQuaid MikeMcQuaid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @Bo98!

@github-actions github-actions bot added the outdated PR was locked due to age label Jul 28, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 28, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@MikeMcQuaid MikeMcQuaid MikeMcQuaid left review comments

@BrewTestBot BrewTestBot BrewTestBot approved these changes

+1 more reviewer

@jgarec jgarec jgarec left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

critical Critical change which should be shipped as soon as possible. outdated PR was locked due to age

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

usage of HOMEBREW_ARTIFACT_DOMAIN broken since 4.0.25

4 participants

@Bo98 @MikeMcQuaid @BrewTestBot @jgarec