Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Increment system command timeout to avoid problems installing some casks #2565

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
danielmartin wants to merge 1 commit into from
Closed

Increment system command timeout to avoid problems installing some casks #2565

danielmartin wants to merge 1 commit into from

Conversation

@danielmartin
Copy link
Contributor

@danielmartin danielmartin commented Apr 29, 2017 •
edited
Loading

Depending on the computer speed and the cask size, the former timeout
caused some problems installing some programs like Google Chrome,
Spotify, or LibreOffice.

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same change?
  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes? Here's an example.
  • Have you successfully run brew tests with your changes locally?

This fixes Homebrew/homebrew-cask#33116 and Homebrew/homebrew-cask#32830

@danielmartin
Increment timeout to 50 seconds
2624cac 
Depending on the computer speed and the cask size, the former timeout
caused some problems installing some programs like Google Chrome,
Spotify, or LibreOffice.
@mislav
Copy link
Contributor

mislav commented May 1, 2017 •
edited
Loading

I can confirm that this makes brew cask install spotify work again, whereas before the hdiutil mount command would consistently fail without anything printed on stderr nor stdout, and the *.dmg file would somehow still remain "in-use" by the diskimage process, preventing it from being downloaded again by the next brew cask install spotify process.

$ lsof ~/Library/Caches/Homebrew/Cask/spotify--latest.dmg
COMMAND     PID   USER   FD   TYPE DEVICE SIZE/OFF    NODE NAME
diskimage 49861 mislav    3r   REG    1,4 97553538 4346868 /Users/mislav/Library/Caches/Homebrew/Cask/spotify--latest.dmg

@reitermarkus
Copy link
Member

reitermarkus commented May 1, 2017

Might be better to fully revert #2517 since this seems to cause more problems than it solves, and could still fail with bigger programs, even with 50 seconds timeout.

@vitorgalvao?

@vitorgalvao
Copy link
Contributor

vitorgalvao commented May 1, 2017

@reitermarkus Agreed on reverting.

@danielmartin
Copy link
Contributor Author

danielmartin commented May 1, 2017

OK, revert PR is here: #2571

@Homebrew Homebrew locked and limited conversation to collaborators May 3, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

HBC reports successful install for pkg casks without installing

4 participants

@danielmartin @mislav @reitermarkus @vitorgalvao