Extract static library and separate main function #324
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Wow, thanks! |
Codecov Report
@@ Coverage Diff @@
## master #324 +/- ##
======================================
Coverage 2.93% 2.93%
======================================
Files 36 36
Lines 2690 2690
Branches 364 358 -6
======================================
Hits 79 79
Misses 2610 2610
Partials 1 1
Continue to review full report at Codecov.
|
1 similar comment
1 similar comment
1 similar comment
|
Fixed last mac issue, merging . . |
This was referenced Oct 24, 2017
Closed
|
Thanks for fixing it. I hoped to at least fix the Windows issue, but get carried away. Will set up env and try to fix it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commits separates main and rest of the code. Main is then used to created QtPass, using rest of the code compiled into static library. The same static library can now be directly linked with unit-tests, so there is no longer need to add separate object files for each test.
Common options moved from
*.protoqtpass.pri.