-
Notifications
You must be signed in to change notification settings - Fork 14
PR Release v0.2.0 #81
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
racousin
wants to merge
29
commits into
main
Choose a base branch
from
dev
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Added flexibility for more variables. Added normalization statistics from graphcast as json files, refactored metrics, datasets and tests as well as lightning modules. The latter have to account for nans in the data when including sea-ice-fraction and others * Added code to zero out NaNs in ground truth values for loss calculation * Renamed stats to norm, changed variable output for label wrapper, applied changes to configs * Removed import that causes error * Replaced norm scheme in graphcast statsconfig * Fixed bug in load_module due to missing stats_cfg and changed behaviour of to_xarray routines to account for levels * Added softlinks recommended by geoarches doc to .gitignore and removed pushed softlinks * Addressed issues with paramaters interpolate_nans and warning_on_nans * Added tensordict utility to test predictions for NaNs * Added documentation to the normalization module, changed name of norm file and norm module according to reviews, adapted norm files * Changes loss_coffs to compute_loss_coeffs_args for clarity, added test for graphcast stats * Added dimension names of the dataset as arguments for the dataloaders, added comment to test of era5 loaders with graphcast norm scheme * Fixed Bug in dcpp test due to missing dimension names * Added more flexibility for data naming (either names have leading zeros or not) * Refactored code to use dimension indexers for selecting dimensions and converting between tensordict and xarray, modified tests * Fixed bug with multistep rollout due to missing next-states, added torch.int64 to allow dates after 2038 * Changed behaviour of dimension indexers, added description, adapted eval_multistep and test files * fixed format problems --------- Co-authored-by: Renu Singh <[email protected]>
14renus
previously approved these changes
Sep 11, 2025
When used in forward_multistep (forecast.py) and in sample_rollout (diffusion.py), we assume lead_time_hours is the timestep in between predictions. Also remove accidentally added lead_time_hours param in forecast.py in commit edfa13
add constant masks for 181x360 data (1deg x 1deg)
(reverting back to old code for now) Robustify tests: - check length - check when lead_time_hours != timedelta_hours
- initialize noise_scheduler outside of jitted function - fix bug in defining self.state_scaler for state_normalization = delta - replace non-jittable iteration over timesteps with torch.searchsorted
* Added flexibility for more variables. Added normalization statistics from graphcast as json files, refactored metrics, datasets and tests as well as lightning modules. The latter have to account for nans in the data when including sea-ice-fraction and others Resolved conflicts during rebase * Renamed stats to norm, changed variable output for label wrapper, applied changes to configs Fixed merge conflicts after rebase dev_diffusion * First changes in stats configs, norm_utils and diffusion module to adapt to more variables Fixed merge conflicts when rebasing dev_diffusion * Commiting changes in forecast and norm_utils.py * Some fixes in the dataloader to use the right time_dim_name * added small fixes to the code, convert_to_xarray converts with default level and time dim name * Revert to old era5 convert to xarray * Updated feature branch with minor changes in the dataloader, added normalization of the forcings to the dataloader Fixed merge conflicts * Added description of stats path to dataset * Fixed problem with debug statement Fixed merge conflicts * Added forcings to default configs * Added fillna in forcings loader * Using interpolate_na along lat instead of fill * Save commit Fixed conflicts * Restored state before changes to fillna Fixed merge conflicts * Make zdim explicit * Added statistics to diff model Fixed merge conflicts * Adapting inference code for predictions * Changed forecast and dataloader nan behaviour Fixed merge conflicts * Reformatted Fixed merge conflicts * Masking mechanism fixed in loss calculation, added interpolation for targets and nans as separate arguments to dataloaders, added explicit norm file argument to stats.yaml and NormalizatinModule Fixed merge conflicts * Refactored style Resolved merge conflicts * Changed position and behaviour of model averaging * Added test * Format fixed Resolved mc * Fixed formatting * Fixed ruff after fixing import error in test * Fixed test problems and formatting * Fixed ruff-format * Fixed ruff format * Fixed lint problem * Formatting fixes * Fixed problems * Format fixes * Changed naming of prediction difference stats, refactored loss coeffs and state scaler into separate method, removed unnecessary args * Fixed test error due to missing level dimension indexer * Moved power statement for scaler and changed mul and div statement in diffusion normalization parts * Document normalization params Added documentation for: residual statistics path, latitude, and WeatherBench latitude coefficients. --------- Co-authored-by: Renu Singh <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's Changed