Native file upload #16 #23
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
otter606
commented
Nov 26, 2022
src/main/java/com/researchspace/dataverse/entities/ObjectOrStringMessageDeserializer.java
Outdated
Show resolved
Hide resolved
AleixMT
reviewed
Nov 26, 2022
| }; | ||
| return getDatasetFileList(metadata, dsIdentifier, resource); | ||
| } | ||
| // TODO stream read twice??? |
Contributor
There was a problem hiding this comment.
What do you mean by read stream twice? Do you have any problem? We can discuss it if you want.
Contributor
|
Generally, I have taken a look into the code and it looks promising :D :D As soon as you do the merge I will try out the new functionalities. I will post how it goes if you want. Thank you! |
otter606
commented
Nov 27, 2022
src/main/java/com/researchspace/dataverse/http/DataverseOperationsImplV1.java
Outdated
Show resolved
Hide resolved
successful post of file
add overloaded method to add input stream fix tests Update src/main/java/com/researchspace/dataverse/entities/ObjectOrStringMessageDeserializer.java docs: javadocs Update src/main/java/com/researchspace/dataverse/http/DataverseOperationsImplV1.java remove obsolete comment
e5d5261 to
d4befed
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@AleixMT here is a PR of intended changes.
It supports upload of file using native API, not Sword.
Please have a look at the new tests in DatasetOperationsTest such as
uploadFileToDataSetWithNativeApiBytesto see how to use it.Any comments welcome