Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Add the SPIRV to LLVM translator. #690

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
vchuravy merged 1 commit into from
Apr 13, 2020
Merged

Add the SPIRV to LLVM translator. #690

vchuravy merged 1 commit into from
Apr 13, 2020

Conversation

@maleadt
Copy link
Member

@maleadt maleadt commented Mar 30, 2020 •
edited
Loading

This tool uses LLVM, so I guess this will be a bit tricky :-) Some thoughts:

@vchuravy
Copy link
Member

vchuravy commented Mar 30, 2020

but I assume we will have a version of libLLVM_jll compatible with other Julia versions?

Yeah we just need to create them and go through a registry dance.

One thing that is getting a bit to manual and complex for my liking is that the current step for building LLVM are:

  1. Open PR to build LLVM_full
  2. Open PR to build libLLVM
  3. Open PR to build Clang/LLVM
  4. Build LLVM_full_assert manually and maybe fix the tag...

all of these PRs need to be correctly staged so that we get the same buildid on the other side.

@vchuravy vchuravy mentioned this pull request Apr 1, 2020
Open
@maleadt
Copy link
Member Author

maleadt commented Apr 13, 2020 •
edited
Loading

I dropped the dependency on libLLVM_jll, as it doesn't seem ready for prime time yet (overwrites files from LLVM_full_jll, not installable on Yggdrasil's Julia due to Compat entries). Will need to add proper Compat entries to this package instead, as well as have it use Julia's libllvm instead the one from libLLVM_jll (but both are assumed to be identical).

@maleadt maleadt marked this pull request as ready for review April 13, 2020 15:33
@vchuravy vchuravy merged commit 7d95f53 into JuliaPackaging:master Apr 13, 2020
@maleadt maleadt deleted the tb/spirv_translator_builder branch April 14, 2020 06:44
@maleadt maleadt mentioned this pull request Apr 21, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@vchuravy vchuravy vchuravy approved these changes

Assignees

No one assigned

Labels

LLVM 🐉

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@maleadt @vchuravy @giordano