Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Conversation

@mgurga
Copy link

@mgurga mgurga commented Jun 21, 2021

Fixes a problem where fullscreen, monocle, and other functions would only use the first monitor. The commit creates a method that finds which monitor a client is on and passes it to the fullscreen, monocle, and other functions. This PR also partly addresses #18.

@JLErvin
Copy link
Owner

JLErvin commented Jun 22, 2021

Hmmmm, this might require a bit of investigation. The purpose of the ws_m_list (which, I think is poorly named and should be more verbose for a variable which has global scope) is to map workspaces onto monitors. Since each client maintains it's active workspace, it should be the case that we can correctly identify which monitor it is on using the list as a lookup. It's likely the case that this is not getting updated properly in some instances - leading to the bug.

I will look into this a bit. I'm quite busy nowadays, however, so if I can't find anything soon I'll just merge this change to be pragmatic.

@ghost
Copy link

ghost commented Oct 5, 2024

I'm sure it's been years since this PR has even been thought of but lack of good multimonitor support (especially with fullscreen behavior) is what got me to move from berry to sway. Is there anything that I could do to help move this along?
@JLErvin @mgurga

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants