fix(deps): use mv instead of cp for library installation #29
Conversation
Replace `cp -n` with `mv -n` in fourq and gflags dependency builds to avoid potential file conflicts during installation. Also comment out unused include directory installation in CMakeLists.txt.
There was a problem hiding this comment.
Summary of Changes
Hello @Jamie-Cui, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!
This pull request refines the build process for external dependencies by switching from copying to moving library files during installation, which helps avoid potential conflicts. Additionally, it cleans up the main CMake configuration by disabling an unnecessary include directory installation.
Highlights
- Dependency Installation: Replaced
cp -nwithmv -nforfourqandgflagslibrary installations to prevent potential file conflicts during the build process. - Build Configuration Cleanup: Commented out an unused
install(${CMAKE_DEPS_INCLUDEDIR})command inCMakeLists.txt.
Using Gemini Code Assist
The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.
Invoking Gemini
You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.
| Feature | Command | Description |
|---|---|---|
| Code Review | /gemini review |
Performs a code review for the current pull request in its current state. |
| Pull Request Summary | /gemini summary |
Provides a summary of the current pull request in its current state. |
| Comment | @gemini-code-assist | Responds in comments when explicitly tagged, both in issue comments and review comments. |
| Help | /gemini help |
Displays a list of available commands. |
Customization
To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.
Limitations & Feedback
Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.
You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.
Footnotes
-
Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩
There was a problem hiding this comment.
Code Review
This pull request aims to resolve potential file conflicts during dependency installation by replacing cp -n with mv -n and commenting out an unused installation command. The changes are generally in the right direction. However, I've identified a significant issue in gflags.cmake where the command being modified is likely redundant and could cause build failures, so I've recommended its removal. I also suggest completely removing the commented-out code in CMakeLists.txt for better maintainability.
| COMMAND mv -n ${CMAKE_DEPS_PREFIX}/lib/libgflags${CMAKE_STATIC_LIBRARY_SUFFIX} | ||
| ${CMAKE_DEPS_LIBDIR}/libgflags${CMAKE_STATIC_LIBRARY_SUFFIX} |
There was a problem hiding this comment.
The gflags project uses CMake, and its install target (executed via INSTALL_COMMAND) should already place the library correctly into ${CMAKE_DEPS_LIBDIR}. This subsequent COMMAND to move the library from a hardcoded ${CMAKE_DEPS_PREFIX}/lib path is redundant and likely to cause build failures.
- If
CMAKE_INSTALL_LIBDIRislib, this command attempts to move a file onto itself. - If
CMAKE_INSTALL_LIBDIRis different (e.g.,lib64), the source file will not exist at the specified path.
This command should be removed, as the INSTALL_COMMAND is sufficient.
| RUNTIME DESTINATION ${CMAKE_INSTALL_PREFIX}/${CMAKE_INSTALL_LIBDIR} | ||
| LIBRARY DESTINATION ${CMAKE_INSTALL_PREFIX}/${CMAKE_INSTALL_LIBDIR}) | ||
|
|
||
| # install(${CMAKE_DEPS_INCLUDEDIR}) |
There was a problem hiding this comment.
This commented-out line appears to be dead code. The original command install(${CMAKE_DEPS_INCLUDEDIR}) has invalid syntax, and the pull request description indicates it's unused. To improve code clarity and maintainability, it's better to remove such dead code entirely rather than commenting it out.
Replace
cp -nwithmv -nin fourq and gflags dependency builds to avoid potential file conflicts during installation. Also comment out unused include directory installation in CMakeLists.txt.