Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Conversation

@mmelko
Copy link
Contributor

@mmelko mmelko commented Mar 24, 2025

This PR extends serialisers metadata to not only store xml declarations but also schemas and namespaces for the root element.

Also when no schema namespace is defined, camel/spring is used as default.
fixes #2087

@codecov
Copy link

codecov bot commented Mar 24, 2025

Codecov Report

Attention: Patch coverage is 95.83333% with 2 lines in your changes missing coverage. Please review.

Project coverage is 81.64%. Comparing base (149df81) to head (b4c7f83).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
...ackages/ui/src/serializers/xml/kaoto-xml-parser.ts 90.90% 2 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##               main    #2112      +/-   ##
============================================
+ Coverage     81.61%   81.64%   +0.02%     
  Complexity      456      456              
============================================
  Files           538      538              
  Lines         17013    17044      +31     
  Branches       3574     3444     -130     
============================================
+ Hits          13886    13915      +29     
- Misses         2868     3044     +176     
+ Partials        259       85     -174     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

…element attributes such as schemas and namespaces
@mmelko mmelko force-pushed the fix/xml-default-ns branch from f93862b to b4c7f83 Compare March 25, 2025 13:31
@sonarqubecloud
Copy link

sonarqubecloud bot commented Mar 25, 2025

Quality Gate Passed Quality Gate passed

Issues
0 New issues
1 Accepted issue

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@lordrip lordrip marked this pull request as ready for review March 25, 2025 16:04
@lordrip lordrip merged commit be15274 into KaotoIO:main Mar 25, 2025
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

XML namespace with xsd association are removed when files are modified

2 participants