fix(DataMapper): Fails to render nested if mappings #2654
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #2654 +/- ##
=======================================
Coverage 84.23% 84.23%
=======================================
Files 499 499
Lines 16146 16150 +4
Branches 3580 3607 +27
=======================================
+ Hits 13600 13604 +4
Misses 2387 2387
Partials 159 159 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
lordrip
reviewed
Oct 23, 2025
| child instanceof FieldItem && acc.push(child); | ||
| if (child instanceof FieldItem) { | ||
| acc.push(child); | ||
| } else if (child instanceof ConditionItem) { |
There was a problem hiding this comment.
Do we need to handle something related to functions? Is there a FunctionItem?
There was a problem hiding this comment.
That might come in when we support custom functions, but not yet ... the function calls inside the xpath expression are handled in xpath.service.
lordrip
approved these changes
Oct 23, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: https://issues.redhat.com/browse/KTO-515
Before
After