Fix EGL render tests for rgba16 and rgb16 unorm fixed point surfaces. #576
+4
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit makes EGL render tests work for 16 bpc RGB16 UNORM and RGBA16 UNORM formats, by adding suitable new formats to getColorFormat. The Mesa open-source graphics library wants to add support to its EGL backend for 16 bpc RGB16 and RGBA16 displayable surfaces and pbuffers to allow rendering and displaying > 10 bpc color precision content on suitable display hardware. As VK-GL-CTS is used as part of Mesa's CI pipeline, this causes test failures due to mismatch between hardware rendered test images and the reference images rendered by the software rasterizer. This is because there isn't a case in getColorFormat to map PACK_FMT's with 16 bpc to a suitable TextureFormat. Adding the needed case handling to getColorFormat does fix this EGL render test failure. Affects: dEQP-EGL.functional.render.* Signed-off-by: Mario Kleiner <[email protected]>
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit makes EGL render tests work for 16 bpc RGB16 UNORM and RGBA16 UNORM formats, by adding suitable new formats to getColorFormat.
The Mesa open-source graphics library wants to add support to its EGL backend for 16 bpc RGB16 and RGBA16 displayable surfaces and pbuffers to allow rendering and displaying > 10 bpc color precision content on suitable display hardware. As VK-GL-CTS is used as part of Mesa's CI pipeline, this causes test failures due to mismatch between hardware rendered test images and the reference images rendered by the software rasterizer. This is because there isn't a case in getColorFormat to map PACK_FMT's with 16 bpc to a suitable TextureFormat.
Adding the needed case handling to getColorFormat does fix this EGL render test failure.
Affects:
dEQP-EGL.functional.render.*