Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Add support for Unix socket path #13

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
djones6 merged 3 commits into from
Mar 25, 2019
Merged

Add support for Unix socket path #13

djones6 merged 3 commits into from
Mar 25, 2019

Conversation

@adellibovi
Copy link
Contributor

@adellibovi adellibovi commented Aug 1, 2017 •
edited
Loading

This add dynamic support for Unix socket path, which is required by Kitura/Kitura-net#213, the idea is dynamically check if the Curl version has this feature.
Can someone point out how to proper check the availability of CURLOPT_UNIX_SOCKET_PATH?

@adellibovi adellibovi mentioned this pull request Aug 1, 2017
Closed
3 tasks
@adellibovi adellibovi changed the title Add support for Unix socket path [WIP] Add support for Unix socket path Aug 1, 2017
@na-gupta
Copy link
Contributor

na-gupta commented Aug 1, 2017

I believe this should work. Could you please fix the indentation.

@adellibovi
Copy link
Contributor Author

adellibovi commented Aug 2, 2017

It looks like this doesn't work on MacOS

@na-gupta
Copy link
Contributor

na-gupta commented Aug 2, 2017

Is your curl version older than 7.40?

@adellibovi
Copy link
Contributor Author

adellibovi commented Aug 3, 2017

Yes

@na-gupta
Copy link
Contributor

na-gupta commented Aug 15, 2017

@adellibovi I have curl version 7.54 on macOS Sierra and this builds fine for me.
I don't recall upgrading curl explicitly, but it's possible it was upgraded as part of another package.

@adellibovi
Copy link
Contributor Author

adellibovi commented Aug 15, 2017

@na-gupta it does compile, but if you try to execute it will get the wrong branch of the if.

@adellibovi adellibovi changed the title [WIP] Add support for Unix socket path Add support for Unix socket path Oct 24, 2017
@adellibovi
Copy link
Contributor Author

adellibovi commented Oct 24, 2017

I fixed the PR can someone review it? Maybe @rfdickerson? :)

@CLAassistant
Copy link

CLAassistant commented Mar 20, 2019 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@djones6
Copy link
Contributor

djones6 commented Mar 22, 2019

@adellibovi Apologies that this stalled for so long. I'd like to resurrect this work as part of adding Unix sockets support to Kitura. If you are still interested in making this contribution, please could you sign the CLA?

@adellibovi
Copy link
Contributor Author

adellibovi commented Mar 22, 2019

@djones6 no prob :) the CLA should be good to go now 🥳

djones6
djones6 approved these changes Mar 25, 2019
View reviewed changes
Copy link
Contributor

@djones6 djones6 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Thanks!

@djones6 djones6 merged commit ef7406e into Kitura:master Mar 25, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@djones6 djones6 djones6 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@adellibovi @na-gupta @CLAassistant @djones6