Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Conversation

@apsteinberg
Copy link
Contributor

Hi there,

Thank you again for creating this wonderful resource. We've been deploying minda across hundreds of our samples, and we discovered one other small bug. Given that you compute precision, recall and the f1 score as:

precision = tp/(tp+fp) 
recall = tp/(tp+fn)
f1 = (2*precision*recall)/(precision+recall)

There is an edge case which can occur if a caller has tp = 0 in which f1 is undefined and minda exits with an error. I added a small if/else statement to handle this in the PR.

Please let me know if this makes sense.

Best wishes,
Asher

@mikolmogorov
Copy link
Contributor

@asherbryant thoughts?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants