Handle edge case where both precision and recall are 0 #14
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi there,
Thank you again for creating this wonderful resource. We've been deploying minda across hundreds of our samples, and we discovered one other small bug. Given that you compute precision, recall and the f1 score as:
There is an edge case which can occur if a caller has tp = 0 in which f1 is undefined and minda exits with an error. I added a small if/else statement to handle this in the PR.
Please let me know if this makes sense.
Best wishes,
Asher