Feat: Adds API Implementation support and external resolution for control planes and gw services #87
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Additionally adds support for external resolution for control planes and gateway services to complete the API Implementation story
There was a problem hiding this comment.
Pull Request Overview
This PR adds API Implementation support and external resolution for control planes and gateway services, completing the API implementation story for control planes and gateway services not managed by declarative configuration.
- Adds external resolution support for control planes and gateway services through
_externalconfiguration blocks - Implements API implementation create/delete operations in the SDK adapter and state client
- Extends test harness to support parameterized endpoints for gateway service creation
Reviewed Changes
Copilot reviewed 26 out of 26 changed files in this pull request and generated 5 comments.
Show a summary per file
| File | Description |
|---|---|
| test/e2e/testdata/declarative/external/core-entities/control-plane-with-gw-svc.yaml | Test data for external control plane with gateway service |
| test/e2e/testdata/declarative/external/core-entities/api.yaml | Test data for API with implementation referencing external services |
| test/e2e/scenarios/external/api-impl/scenario.yaml | E2E test scenario for API implementation with external services |
| test/e2e/harness/step.go | Adds parameterized endpoint support for resource creation |
| test/e2e/harness/scenario/types.go | Adds EndpointParams field to CreateSpec |
| test/e2e/harness/scenario/run.go | Implements endpoint parameter template resolution |
| internal/konnect/helpers/services.go | Defines GatewayServiceAPI interface |
| internal/konnect/helpers/sdk_mock.go | Adds mock support for GatewayServiceAPI |
| internal/konnect/helpers/sdk.go | Implements GatewayServiceAPI in KonnectSDK |
| internal/konnect/helpers/api_implementations.go | Adds create/delete methods to APIImplementationAPI |
| internal/declarative/state/client.go | Adds gateway service listing and API implementation CRUD operations |
| internal/declarative/resources/types.go | Adds GatewayServiceResource type and registration |
| internal/declarative/resources/gateway_service.go | Implements GatewayServiceResource with external resolution support |
| internal/declarative/resources/control_plane.go | Adds external resolution and nested gateway services support |
| internal/declarative/resources/api_implementation.go | Updates service reference validation to support gateway service refs |
| internal/declarative/planner/types.go | Adds HasChange method to prevent duplicate planning |
| internal/declarative/planner/portal_child_planner.go | Uses HasChange to prevent duplicate portal child resource planning |
| internal/declarative/planner/planner.go | Implements gateway service and API implementation service reference resolution |
| internal/declarative/planner/control_plane_planner.go | Skips external control planes in planning |
| internal/declarative/planner/api_planner.go | Enables API implementation create/delete and adds duplicate prevention |
| internal/declarative/loader/validator.go | Adds gateway service validation |
| internal/declarative/loader/ref_resolver.go | Adds gateway service reference resolution |
| internal/declarative/loader/loader.go | Extracts nested gateway services from control planes |
| internal/declarative/executor/executor.go | Updates API implementation executor type |
| internal/declarative/executor/api_implementation_adapter.go | Implements actual create/delete operations for API implementations |
| internal/cmd/root/products/konnect/declarative/declarative.go | Configures GatewayServiceAPI in state client |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This helps complete the API implementation story for CPs and GW Services not managed by declarative configuration