Adds support for Control Plane Resource Groups #94
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR adds support for Control Plane Resource Groups in the Konnect declarative configuration, enabling control planes to function as groups with managed memberships.
Key changes:
- Introduced
ControlPlaneGroupsAPIinterface and integration throughout the SDK, client, and planning layers - Added
membersfield to control plane resources with validation for group-specific constraints - Implemented membership synchronization during create/update operations with reference resolution
Reviewed Changes
Copilot reviewed 16 out of 16 changed files in this pull request and generated 4 comments.
Show a summary per file
| File | Description |
|---|---|
| internal/konnect/helpers/sdk_mock.go | Added mock factory for ControlPlaneGroupsAPI |
| internal/konnect/helpers/sdk.go | Added GetControlPlaneGroupsAPI method to SDK interface |
| internal/declarative/state/client_control_plane_test.go | Added tests for listing and upserting control plane group memberships |
| internal/declarative/state/client.go | Added membership listing/upserting methods and cursor extraction helper |
| internal/declarative/resources/types.go | Added GetControlPlaneByRef helper method |
| internal/declarative/resources/resources_test.go | Added validation tests for control plane groups with members |
| internal/declarative/resources/control_plane.go | Added ControlPlaneGroupMember type and member validation logic |
| internal/declarative/planner/dependencies.go | Added array reference dependency resolution |
| internal/declarative/planner/control_plane_planner_test.go | Added tests for planning group creation and member updates |
| internal/declarative/planner/control_plane_planner.go | Implemented member tracking, normalization, and reference building |
| internal/declarative/executor/executor.go | Added member resolution and synchronization during resource operations |
| internal/declarative/executor/control_plane_operations_test.go | Added test for group member sync on create |
| internal/cmd/root/verbs/dump/declarative.go | Added group membership fetching and normalization in dump command |
| internal/cmd/root/products/konnect/declarative/declarative.go | Wired ControlPlaneGroupsAPI into state client |
| docs/examples/declarative/control-plane/README.md | Added control plane group example reference |
| docs/declarative.md | Added documentation for control plane groups feature |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.