Remove staterefs from ref cache on unmount #231
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit adds tests to assert that the `StateRef` created by calling `useSwrv()` is removed from the data array held in the `REF_CACHE`. N.B. These tests fail at this commit.
Prior to this commit, the `REF_CACHE` with the default time-to-live of `0` retained the `StateRef`s that were added to it even after the component that called `useSwrv()` was unmounted (destroyed). This allowed the `REF_CACHE` to grow indefinitely as components that called `useSwrv()` were created and destroyed. This commit extends the callback passed to `onUnmounted()` that removes the `StateRef` created by the current invocation of `useSwrv()` from the array stored in the `REF_CACHE` at the given key.
|
|
|
hey @jefrailey thanks for this patch! I've approved the build to run which is now failing. Can you fix the lint issues? Can approve afterwards. Thanks for the tests! |
|
@darrenjennings Will do. It looks like it's all formatting issues--looks like I forgot to run |
|
hi guys could be great also for the beta if the bug exist of course ^^ Vue3 🚀 |
darrenjennings
pushed a commit
that referenced
this pull request
Mar 12, 2022
Eliminate a (slight) memory leak caused by the indefinite retention of StateRefs by the REF_CACHE when the time-to-live is 0 by removing a StateRef from the REF_CACHE when its component is unmounted (reported in #230).
darrenjennings
pushed a commit
that referenced
this pull request
Mar 12, 2022
Eliminate a (slight) memory leak caused by the indefinite retention of StateRefs by the REF_CACHE when the time-to-live is 0 by removing a StateRef from the REF_CACHE when its component is unmounted (reported in #230).
adamdehaven
pushed a commit
that referenced
this pull request
Aug 25, 2022
Eliminate a (slight) memory leak caused by the indefinite retention of StateRefs by the REF_CACHE when the time-to-live is 0 by removing a StateRef from the REF_CACHE when its component is unmounted (reported in #230).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Goal
Eliminate a (slight) memory leak caused by the indefinite retention of
StateRefs by theREF_CACHEwhen the time-to-live is0by removing aStateReffrom theREF_CACHEwhen its component is unmounted (reported in #230).How Can This Be Tested?
yarnyarn testyarn testEDIT: Corrected commit order.