Describe moving kotlinx.datetime.Instant to stdlib #387

dkhalanskyjb · 2024-08-22T08:17:35Z

Issue: #395

proposals/stdlib/instant.md

JakeWharton · 2024-08-22T11:55:51Z

proposals/stdlib/instant.md

+```
+
+```kotlin
+// Darwin


According to the UUID KEEP, the stdlib is not specialized for various native targets today. These extensions would no longer be possible.

Let's move them to the "Future enhancements" section

We also need to update KDoc in the corresponding implementation. @dkhalanskyjb

We also need to update KDoc in the corresponding implementation.

Never mind, it looks OK as of now.

proposals/stdlib/instant.md

lukellmann · 2024-08-22T21:16:45Z

proposals/stdlib/instant.md

+It is not obvious to people who want to obtain the current `Instant` that a
+class like `Clock` even exists, so we direct them to it using a deprecation with
+a proposed replacement.


Isn't documentation for the Instant class enough?

If anyone does read it, it should be enough. Instant.now() is for establishing a smooth enough migration using the compiler errors that it's straightforward to arrive at correct code without reading anything, just with autocomplete.

proposals/stdlib/instant.md

lukellmann · 2024-10-02T14:21:20Z

proposals/stdlib/instant.md

+ * ### Platform specifics
+ *
+ * On the JVM, there are `Instant.toJavaInstant()` and `java.time.Instant.toKotlinInstant()`
+ * extension functions to convert between `kotlinx.datetime` and `java.time` objects used for the same purpose.


The package is no longer kotlinx.datetime.

lukellmann · 2024-10-02T18:26:05Z

proposals/stdlib/instant.md

+leap seconds.
+
+<https://github.com/ThreeTen/threeten-extra/tree/4e016340b97cab604114d10e02a672c1e94c6be5/src/main/java/org/threeten/extra/scale>
+is an implementation that converts between "UTC `Instant`", a new class, and


Suggested change

is an implementation that converts between "UTC `Instant`", a new class, and

is an implementation that converts between "`UtcInstant`", a new class, and

assuming you wanted to mention the actual class name

@dkhalanskyjb should we use the actual class name here?

I don't think the name of the class is important here. If it were called LeapSecondAwareInstant or something similar, I'd still prefer calling it a "UTC Instant", that is, an Instant using the UTC time-scale.

proposals/stdlib/instant.md

Co-authored-by: Luca Kellermann <[email protected]>

proposals/stdlib/instant.md

fvasco · 2024-10-25T13:13:34Z

The Java Time API defined by JSR 310 is provided as part of JDK-8

https://jcp.org/aboutJava/communityprocess/pfd/jsr310/JSR-310-guide.html

proposals/stdlib/instant.md

Can be merged after moving to Kotlin 2.1.20, which introduces kotlin.time.Instant. Previously, when kotlinx.datetime.Instant serializers were available in kotlinx-datetime. See Kotlin/KEEP#387

kotlinx.datetime.Instant entered the stdlib as kotlin.time.Instant, and so kotlinx.serialization takes over its serializers. See Kotlin/KEEP#387

Can be merged after moving to Kotlin 2.1.20, which introduces kotlin.time.Instant. kotlinx.datetime.Instant entered the stdlib as kotlin.time.Instant, and so kotlinx.serialization takes over its serializers. See Kotlin/KEEP#387

ilya-g · 2025-03-04T16:16:08Z

proposals/stdlib/instant.md

+nondeterministic and difficult to reliably test, whereas passing a `Clock`
+to it makes calling `now()` a functionally pure operation.
+
+### Migration process


I'd leave a description of that process we've chosen to implement.

I meant leave only that description because having others at this point doesn't bring much use and can lead to confusion for those reading this and trying to figure out what to expect from this change migration-wise.

proposals/stdlib/instant.md

Co-authored-by: ilya-g <[email protected]>

Co-authored-by: Abduqodiri Qurbonzoda <[email protected]>

After moving `Instant` from `kotlinx.datetime` to `kotlin.time`, we also need to preserve it having a default `kotlinx.serialization` serializer. See Kotlin/KEEP#387 The corresponding request in `kotlinx.serialization`: Kotlin/kotlinx.serialization#2945

…rializers After moving `Instant` from `kotlinx.datetime` to `kotlin.time`, we also need to preserve it having a default `kotlinx.serialization` serializer. See Kotlin/KEEP#387 The corresponding request in `kotlinx.serialization`: Kotlin/kotlinx.serialization#2945 Additionally, fix a test that was not being run correctly. Merge-request: KT-MR-20493 Merged-by: Dmitry Khalanskiy <[email protected]>

fzhinkin

@dkhalanskyjb could you please address remaining open questions (about interop with Foundation libraries, mainly)?

Otherwise, LGTM

ilya-g

It's better to leave only the actual chosen migration process description.

Can be merged after moving to Kotlin 2.1.20, which introduces kotlin.time.Instant. kotlinx.datetime.Instant entered the stdlib as kotlin.time.Instant, and so kotlinx.serialization takes over its serializers. See Kotlin/KEEP#387

Add kotlin.time.Instant serializers kotlinx.datetime.Instant entered the stdlib as kotlin.time.Instant, and so kotlinx.serialization takes over its serializers. (toString() one and ComponentSerializer). See Kotlin/KEEP#387 * Move the tests for the Instant serializers Original version: https://github.com/Kotlin/kotlinx-datetime/blob/72681c2acaf9addf5effdef8ecd0975f6f7d10a7/serialization/common/test/InstantSerializationTest.kt * Improve the documentation

JakeWharton reviewed Aug 22, 2024

View reviewed changes

lukellmann reviewed Aug 22, 2024

View reviewed changes

fvasco reviewed Aug 23, 2024

View reviewed changes

proposals/stdlib/instant.md Outdated Show resolved Hide resolved

proposals/stdlib/instant.md Outdated Show resolved Hide resolved

Describe moving kotlinx.datetime.Instant to stdlib

7eabfbe

dkhalanskyjb force-pushed the dkhalanskyjb-instant branch from 3852f17 to 7eabfbe Compare October 1, 2024 13:24

dkhalanskyjb marked this pull request as ready for review October 1, 2024 13:24

dkhalanskyjb mentioned this pull request Oct 1, 2024

kotlin.time.Instant #395

Closed

benjishults reviewed Oct 2, 2024

View reviewed changes

proposals/stdlib/instant.md Outdated Show resolved Hide resolved

lukellmann reviewed Oct 4, 2024

View reviewed changes

dkhalanskyjb and others added 3 commits October 7, 2024 12:21

Update proposals/stdlib/instant.md

9f1f0b4

Co-authored-by: Luca Kellermann <[email protected]>

Corrections and an alternative migration process

58358e9

Fix the incorrect statement about compile-time compatibility

1667038

lukellmann reviewed Oct 25, 2024

View reviewed changes

proposals/stdlib/instant.md Outdated Show resolved Hide resolved

Fix the wrong Java version in the historical note

2554be8

qurbonzoda reviewed Dec 10, 2024

View reviewed changes

proposals/stdlib/instant.md Outdated Show resolved Hide resolved

dkhalanskyjb mentioned this pull request Mar 4, 2025

Add kotlin.time.Instant serializers Kotlin/kotlinx.serialization#2945

Merged

ilya-g reviewed Mar 4, 2025

View reviewed changes

proposals/stdlib/instant.md Show resolved Hide resolved

dkhalanskyjb and others added 2 commits March 6, 2025 12:35

Update proposals/stdlib/instant.md

0d01dab

Co-authored-by: ilya-g <[email protected]>

Update proposals/stdlib/instant.md

3417029

Co-authored-by: Abduqodiri Qurbonzoda <[email protected]>

Describe the process we ended up with

e636c1a

dkhalanskyjb force-pushed the dkhalanskyjb-instant branch from bb89c13 to e636c1a Compare March 6, 2025 12:08

dkhalanskyjb requested review from fzhinkin and ilya-g March 7, 2025 10:39

fzhinkin requested changes Mar 10, 2025

View reviewed changes

Document the problem with the Darwin-specific converters

adcab2d

dkhalanskyjb requested a review from fzhinkin March 11, 2025 05:39

fzhinkin approved these changes Mar 11, 2025

View reviewed changes

ilya-g requested changes Mar 12, 2025

View reviewed changes

Only describe the final migration process

982d2f6

dkhalanskyjb requested a review from ilya-g March 17, 2025 14:04

ilya-g approved these changes Mar 20, 2025

View reviewed changes

dkhalanskyjb merged commit 0d403e2 into Kotlin:master Mar 20, 2025

dkhalanskyjb deleted the dkhalanskyjb-instant branch March 20, 2025 15:10

dkhalanskyjb mentioned this pull request Jun 30, 2025

Kotlinx.datetime.Instant removed, but no replacement serializer provided Kotlin/kotlinx.serialization#3026

Closed

	is an implementation that converts between "UTC `Instant`", a new class, and
	is an implementation that converts between "`UtcInstant`", a new class, and

Describe moving kotlinx.datetime.Instant to stdlib #387

Describe moving kotlinx.datetime.Instant to stdlib #387

Uh oh!

Conversation

dkhalanskyjb commented Aug 22, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

fvasco commented Oct 25, 2024

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

ilya-g Mar 11, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

fzhinkin left a comment

Choose a reason for hiding this comment

Uh oh!

ilya-g left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

8 participants

dkhalanskyjb commented Aug 22, 2024 •

edited

Loading

ilya-g Mar 11, 2025 •

edited

Loading