Fix configure version eagerly #2799
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A typical approach in some version plugins is using an object which uses internally a `Property<String>`, and the `toString()` method unwraps it.
With `provider { … }` unwrapping it too soon is avoided.
|
For some additional context: the problem was reported by another user in the Kotlin Community Slack (link to the message), whose project version was all of a sudden changed to |
IgnatBeresnev
approved these changes
Jan 9, 2023
|
Looks good, thanks once again! |
|
You're welcome 🤗 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A typical approach in some version plugins is using an object which uses internally a
Property<String>, and thetoString()method unwraps it.With
provider { … }unwrapping it too soon is avoided.