consistently apply Gradle Build Cache config in all includedBuild projects #3522
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
whyoleg
approved these changes
Mar 8, 2024
build-settings-logic/src/main/kotlin/dokkasettings.build-cache.settings.gradle.kts
Show resolved
Hide resolved
… here) The build scan URL is configurable because it used to control whether someone could opt in/out of build scans, but since then an explicit option has been added, so it makes sense to hardcode the build scan url.
dkrasnoff
approved these changes
Mar 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently the plugin-includedBuild projects
build-logicandbuild-settings-logicdo not have Build Cache enabled. This hurts build performance, and Dokka gets dinged with a build scan warning.This PR shares the build cache config in all projects, improving build performance.
Convention plugin workaround.
In
build-settings-logicthere's a chicken-and-egg situation: a project can't apply its own convention plugin to itself.Instead, I've applied a hack to apply the build cache config as a script plugin. (Space also applies the same quick-fix.)